cloud-fan commented on PR #38793: URL: https://github.com/apache/spark/pull/38793#issuecomment-1328558979
My two cents: In general, I agree with @amaliujia that we should not reuse a proto message with a mismatched semantic. But we should define the semantic by the proto message itself, not the DataFrame API. For a `WithColumns` operator, I think using `Alias` matches its semantic (add/replace columns with the provided expressions according to the provided names). The problem I see here is `Alias` can contain a list of alias names. We should either document it clearly that `WithColumns` can only use `Alias` with a single alias name, or introduce `MultiAlias` like what catalyst does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
