grundprinzip commented on PR #38793: URL: https://github.com/apache/spark/pull/38793#issuecomment-1328586566
I don't think anyone is disputing that reusing messages in different contexts just because the fields are identical is a bad idea. One thing I'm wondering and I'm sorry that I didn't bring this up earlier is if we shouldn't implement WithColum using a Projection? The main difference I see is that to make projection work we have to resolve the schema to be able to append columns. Maybe we can do Project[*, add columns]? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
