LuciferYang commented on code in PR #38754:
URL: https://github.com/apache/spark/pull/38754#discussion_r1033358837
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala:
##########
@@ -160,8 +157,8 @@ object DataType {
try {
fallbackParser(schema)
} catch {
- case NonFatal(e2) =>
- throw QueryCompilationErrors.failedFallbackParsingError(errorMsg,
e1, e2)
+ case NonFatal(_) =>
Review Comment:
Do you mean if `e2` is `NonFatal ` and `e1` is `SparkThrowable`, then
re-throw it, and only call `QueryCompilationErrors.schemaFailToParseError`
when e1 is not `SparkThrowable`?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala:
##########
@@ -160,8 +157,8 @@ object DataType {
try {
fallbackParser(schema)
} catch {
- case NonFatal(e2) =>
- throw QueryCompilationErrors.failedFallbackParsingError(errorMsg,
e1, e2)
+ case NonFatal(_) =>
Review Comment:
Do you mean if `e2` is `NonFatal ` and `e1` is `SparkThrowable`, then
re-throw it, and only call `QueryCompilationErrors.schemaFailToParseError`
when `e1` is not `SparkThrowable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
