LuciferYang commented on code in PR #38754:
URL: https://github.com/apache/spark/pull/38754#discussion_r1033411900
##########
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala:
##########
@@ -991,22 +1003,47 @@ class JsonFunctionsSuite extends QueryTest with
SharedSparkSession {
test("SPARK-33286: from_json - combined error messages") {
val df = Seq("""{"a":1}""").toDF("json")
val invalidJsonSchema = """{"fields": [{"a":123}], "type": "struct"}"""
- val errMsg1 = intercept[AnalysisException] {
- df.select(from_json($"json", invalidJsonSchema, Map.empty[String,
String])).collect()
- }.getMessage
- assert(errMsg1.contains("""Failed to convert the JSON string '{"a":123}'
to a field"""))
+ val invalidJsonSchemaReason = "Failed to convert the JSON string
'{\"a\":123}' to a field."
Review Comment:
The following three case corresponding to `e` is not `SparkThrowable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
