amaliujia commented on code in PR #38806:
URL: https://github.com/apache/spark/pull/38806#discussion_r1034278581
##########
python/pyspark/sql/connect/column.py:
##########
@@ -314,3 +323,62 @@ def to_plan(self, session: "RemoteSparkSession") ->
proto.Expression:
def __str__(self) -> str:
return f"({self._op} ({', '.join([str(x) for x in self._args])}))"
+
+
+class Column(object):
Review Comment:
This is my question given I am not familiar with PySpark:
If we have a base class `Column` and then have many sub-class inherits it to
form the Expression family, does it count as leaking internal implementation to
users for PySpark or Python users when they start to use Spark Connect Python
client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
