cloud-fan commented on code in PR #38806:
URL: https://github.com/apache/spark/pull/38806#discussion_r1034443578
##########
python/pyspark/sql/connect/column.py:
##########
@@ -314,3 +323,62 @@ def to_plan(self, session: "RemoteSparkSession") ->
proto.Expression:
def __str__(self) -> str:
return f"({self._op} ({', '.join([str(x) for x in self._args])}))"
+
+
+class Column(object):
Review Comment:
@grundprinzip can you give your opinion clearly? It seems most reviewers
here agree to have `Column` wrapping `Expression`, as it can hide the
implementation details the most. It's also consistent with `DataFrame` wrapping
`LogicalPlan` in Spark Connect today. Are you OK with moving forward with this
design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
