rmcyang commented on code in PR #37638:
URL: https://github.com/apache/spark/pull/37638#discussion_r1034531438
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RemoteBlockPushResolverSuite.java:
##########
@@ -1415,6 +1440,24 @@ private void pushBlockHelper(
}
}
+ private void verifyMetrics(
Review Comment:
Sure, I enhanced the UTs `testDeferredBufsAreWrittenDuringOnData` and
`testDeferredBufsAreWrittenDuringOnComplete` to cover the test for
`expectedCachedBlocksBytes` since the UTs produced the cached block bytes.
Thanks for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
