grundprinzip commented on code in PR #38866:
URL: https://github.com/apache/spark/pull/38866#discussion_r1037576399
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -721,8 +721,19 @@ def plan(self, session: "SparkConnectClient") ->
proto.Relation:
rel.join.using_columns.append(self.on)
else:
rel.join.join_condition.CopyFrom(self.to_attr_or_expression(self.on, session))
- else:
- rel.join.using_columns.extend(self.on)
+ elif len(self.on) > 0:
+ if isinstance(self.on[0], str):
+ rel.join.using_columns.extend(self.on) # ignore: arg-type
+ else:
+ merge_column = None
+ for c in self.on:
+ if merge_column is not None:
+ merge_column = merge_column & c
+ else:
+ merge_column = c
+ rel.join.join_condition.CopyFrom(
+ merge_column.to_plan(session) # ignore: union-attr
Review Comment:
So here the challenge is: if self.on is empty, merge_column is None
(Optional). On itself is defined as either str, Column or None, so when you
asign it might be any of those.
My suggestion would be to add proper isinstance checks or do a manual
conversion to the expected type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
