HyukjinKwon commented on code in PR #38866:
URL: https://github.com/apache/spark/pull/38866#discussion_r1037706761
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -468,7 +468,7 @@ def take(self, num: int) -> List[Row]:
def join(
self,
other: "DataFrame",
- on: Optional[Union[str, List[str], Column]] = None,
+ on: Optional[Union[str, List[str], Column, List[Column]]] = None,
Review Comment:
Just dropping a comment. It should actually be able to accept a tuple too ..
or `Iterable` .. but I am fine because that's what's already done in PySpark
DataFrame.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
