amaliujia commented on code in PR #38866:
URL: https://github.com/apache/spark/pull/38866#discussion_r1037741383
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -721,8 +721,17 @@ def plan(self, session: "SparkConnectClient") ->
proto.Relation:
rel.join.using_columns.append(self.on)
else:
rel.join.join_condition.CopyFrom(self.to_attr_or_expression(self.on, session))
- else:
- rel.join.using_columns.extend(self.on)
+ elif len(self.on) > 0:
Review Comment:
After check the Scala Dataset, I believe that does not do such validation so
I assume Dataset also choose to leave Calalyst to handle such case.
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -721,8 +721,17 @@ def plan(self, session: "SparkConnectClient") ->
proto.Relation:
rel.join.using_columns.append(self.on)
else:
rel.join.join_condition.CopyFrom(self.to_attr_or_expression(self.on, session))
- else:
- rel.join.using_columns.extend(self.on)
+ elif len(self.on) > 0:
Review Comment:
After check the Scala Dataset, I believe that does not do such validation so
I assume Dataset also choose to leave Catalyst to handle such case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
