LuciferYang commented on code in PR #38711: URL: https://github.com/apache/spark/pull/38711#discussion_r1037869060
########## core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala: ########## @@ -55,7 +55,8 @@ case class SparkListenerTaskGettingResult(taskInfo: TaskInfo) extends SparkListe @DeveloperApi case class SparkListenerSpeculativeTaskSubmitted( Review Comment: If you want `taskIndex` to be a `val`, maybe we can consider using a size 1 `Array` as an container, and add two function to update and get the Array(0) as `taskIndex` ########## core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala: ########## @@ -55,7 +55,8 @@ case class SparkListenerTaskGettingResult(taskInfo: TaskInfo) extends SparkListe @DeveloperApi case class SparkListenerSpeculativeTaskSubmitted( Review Comment: If we want `taskIndex` to be a `val`, maybe we can consider using a size 1 `Array` as an container, and add two function to update and get the Array(0) as `taskIndex` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
