cloud-fan commented on code in PR #38873:
URL: https://github.com/apache/spark/pull/38873#discussion_r1037897941
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java:
##########
@@ -125,32 +125,45 @@ public static Map<Integer, Integer>
toJavaIntMap(ColumnarMap map) {
}
private static void appendValue(WritableColumnVector dst, DataType t, Object
o) {
Review Comment:
If this function is to handle external types (Row), I think matching logical
data type makes more sense, as external types are bound to logical types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
