LuciferYang commented on code in PR #38873:
URL: https://github.com/apache/spark/pull/38873#discussion_r1037904653
##########
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java:
##########
@@ -125,32 +125,45 @@ public static Map<Integer, Integer>
toJavaIntMap(ColumnarMap map) {
}
private static void appendValue(WritableColumnVector dst, DataType t, Object
o) {
Review Comment:
OK, I will revert the change of this method, but there maybe 2 problem:
- TimestampType is not handled, will throw `UnsupportedOperationException`
directly
- appendValue method not handle MapType yet
seems that another pr is needed to solve these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
