dongjoon-hyun commented on code in PR #38943:
URL: https://github.com/apache/spark/pull/38943#discussion_r1041347366


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -101,6 +100,17 @@ private[spark] object Config extends Logging {
       .booleanConf
       .createWithDefault(true)
 
+  val KUBERNETES_DRIVER_WAIT_TO_REUSE_PVC =
+    ConfigBuilder("spark.kubernetes.driver.waitToReusePersistentVolumeClaims")
+      .doc("If true, driver pod counts the number of created on-demand 
persistent volume claims " +
+        s"and wait if the number is greater than or equal to the maximum which 
is " +
+        s"${EXECUTOR_INSTANCES.key} or ${DYN_ALLOCATION_MAX_EXECUTORS.key}. " +
+        s"This config requires both ${KUBERNETES_DRIVER_OWN_PVC.key}=true and 
" +
+        s"${KUBERNETES_DRIVER_REUSE_PVC.key}=true.")

Review Comment:
   Yes, initially, I tried to use it as a config name but `PVC-oriented 
executor pod allocation` was achieved by three configurations.
   - spark.kubernetes.driver.waitToReusePersistentVolumeClaims
   - spark.kubernetes.driver.ownPersistentVolumeClaims
   - spark.kubernetes.driver.reusePersistentVolumeClaims
   
   I'll add a K8s document section with that name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to