viirya commented on code in PR #38943:
URL: https://github.com/apache/spark/pull/38943#discussion_r1041414732
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala:
##########
@@ -47,6 +48,17 @@ class ExecutorPodsAllocator(
private val EXECUTOR_ID_COUNTER = new AtomicInteger(0)
+ private val PVC_COUNTER = new AtomicInteger(0)
+
+ private val maxPVCs = if (Utils.isDynamicAllocationEnabled(conf)) {
+ conf.get(DYN_ALLOCATION_MAX_EXECUTORS)
+ } else {
+ conf.getInt(EXECUTOR_INSTANCES.key, DEFAULT_NUMBER_EXECUTORS)
+ }
+
+ private val reusePVC = conf.get(KUBERNETES_DRIVER_OWN_PVC) &&
+ conf.get(KUBERNETES_DRIVER_REUSE_PVC) &&
conf.get(KUBERNETES_DRIVER_WAIT_TO_REUSE_PVC)
Review Comment:
I think this named `reusePVC` is a bit confused. Isn't it the combination of
three configs you mentioned
(https://github.com/apache/spark/pull/38943/files#r1041347366)?
Maybe `podAllocOnPVC`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
