dongjoon-hyun commented on PR #38943: URL: https://github.com/apache/spark/pull/38943#issuecomment-1340224815
In case of creation failure, `PVC_COUNTER.incrementAndGet()` is not invoked. https://github.com/apache/spark/blob/e58f12d1843af39ed4ac0c2ff108490ae303e7e4/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala#L447-L448 In case of deletion failure, `PVC_COUNTER.decrementAndGet()` is not invoked. https://github.com/apache/spark/blob/e58f12d1843af39ed4ac0c2ff108490ae303e7e4/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala#L454-L458 So, we had better remove `PVC_COUNTER.decrementAndGet()`, right? If you agree, I will make a follow-up for the deletion of `PVC_COUNTER.decrementAndGet()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
