viirya commented on code in PR #38993:
URL: https://github.com/apache/spark/pull/38993#discussion_r1044740898
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/LogDivertAppender.java:
##########
@@ -276,12 +276,19 @@ private static StringLayout
initLayout(OperationLog.LoggingLevel loggingMode) {
return getLayout(isVerbose, layout);
}
- public LogDivertAppender(OperationManager operationManager,
- OperationLog.LoggingLevel loggingMode) {
+ public static LogDivertAppender create(OperationManager operationManager,
+ OperationLog.LoggingLevel
loggingMode) {
+ CharArrayWriter writer = new CharArrayWriter();
+ return new LogDivertAppender(operationManager, loggingMode, writer);
+ }
+
+ private LogDivertAppender(OperationManager operationManager,
+ OperationLog.LoggingLevel loggingMode, CharArrayWriter writer) {
Review Comment:
Isn't it just to create `CharArrayWriter` in original constructor?
```suggestion
public LogDivertAppender(OperationManager operationManager,
OperationLog.LoggingLevel
loggingMode) {
CharArrayWriter writer = new CharArrayWriter();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
