idealspark commented on code in PR #38993:
URL: https://github.com/apache/spark/pull/38993#discussion_r1044969362
##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/LogDivertAppender.java:
##########
@@ -276,12 +276,19 @@ private static StringLayout
initLayout(OperationLog.LoggingLevel loggingMode) {
return getLayout(isVerbose, layout);
}
- public LogDivertAppender(OperationManager operationManager,
- OperationLog.LoggingLevel loggingMode) {
+ public static LogDivertAppender create(OperationManager operationManager,
+ OperationLog.LoggingLevel
loggingMode) {
+ CharArrayWriter writer = new CharArrayWriter();
+ return new LogDivertAppender(operationManager, loggingMode, writer);
+ }
+
+ private LogDivertAppender(OperationManager operationManager,
+ OperationLog.LoggingLevel loggingMode, CharArrayWriter writer) {
Review Comment:
this is no way to create CharArrayWriter in original constructor.
because original constructor first need call supper constructor. supper
constructor need a CharArrayWriter as parameter.
```
private LogDivertAppender(OperationManager operationManager,
OperationLog.LoggingLevel loggingMode, CharArrayWriter writer) {
super("LogDivertAppender", initLayout(loggingMode), null, false, true,
Property.EMPTY_ARRAY,
new WriterManager(writer, "LogDivertAppender",
initLayout(loggingMode), true));
}
```
if create CharArrayWriter in original constructor like you suggest compile
will failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
