anchovYu commented on code in PR #38776:
URL: https://github.com/apache/spark/pull/38776#discussion_r1044744657
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -638,6 +638,14 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog with QueryErrorsB
case UnresolvedWindowExpression(_, windowSpec) =>
throw
QueryCompilationErrors.windowSpecificationNotDefinedError(windowSpec.name)
})
+ // This should not happen, resolved Project or Aggregate should
restore or resolve
+ // all lateral column alias references. Add check for extra safe.
Review Comment:
I didn't add it intentionally. This is because I don't want those attributes
actually can be resolve as LCA but to show in the error msg as
UnresolvedAttribute. Also note that unlike RemoveTempResolvedColumn, LCARef
can't be directly resolved to the NamedExpression inside of it because the plan
won't be right - there is no alias push down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
