itholic commented on code in PR #39137: URL: https://github.com/apache/spark/pull/39137#discussion_r1053172074
########## python/pyspark/errors/errors.py: ########## @@ -0,0 +1,93 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from typing import Union, Any, Type +from pyspark.errors.exceptions import PySparkException +from py4j.java_gateway import JavaClass + + +def _get_pyspark_errors() -> JavaClass: + from pyspark.sql import SparkSession + + spark = SparkSession._getActiveSessionOrCreate() + assert spark._jvm is not None + return spark._jvm.org.apache.spark.python.errors.PySparkErrors + + +def columnInListError(func_name: str) -> "PySparkException": Review Comment: I following the camelCase naming rule for errors to facilitate matching with errors defined on the JVM side (`sql/catalyst/src/main/scala/org/apache/spark/python/errors/PySparkErrors.scala`) ########## python/pyspark/errors/errors.py: ########## @@ -0,0 +1,93 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from typing import Union, Any, Type +from pyspark.errors.exceptions import PySparkException +from py4j.java_gateway import JavaClass + + +def _get_pyspark_errors() -> JavaClass: + from pyspark.sql import SparkSession + + spark = SparkSession._getActiveSessionOrCreate() + assert spark._jvm is not None + return spark._jvm.org.apache.spark.python.errors.PySparkErrors + + +def columnInListError(func_name: str) -> "PySparkException": Review Comment: I follows the camelCase naming rule for errors to facilitate matching with errors defined on the JVM side (`sql/catalyst/src/main/scala/org/apache/spark/python/errors/PySparkErrors.scala`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
