MaxGekk commented on code in PR #39137:
URL: https://github.com/apache/spark/pull/39137#discussion_r1053437112
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1046,6 +1046,63 @@
"Protobuf type not yet supported: <protobufType>."
]
},
+ "PYSPARK" : {
+ "message" : [
+ ""
+ ],
+ "subClass" : {
+ "COLUMN_IN_LIST" : {
+ "message" : [
+ "<funcName> does not allow a column in a list"
+ ]
+ },
+ "HIGHER_ORDER_FUNCTION_SHOULD_RETURN_COLUMN" : {
+ "message" : [
+ "Function '<funcName>' should return Column, got <returnType>"
Review Comment:
`'<funcName>'` should be quoted by backticks.
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1046,6 +1046,63 @@
"Protobuf type not yet supported: <protobufType>."
]
},
+ "PYSPARK" : {
+ "message" : [
+ ""
+ ],
+ "subClass" : {
+ "COLUMN_IN_LIST" : {
+ "message" : [
+ "<funcName> does not allow a column in a list"
+ ]
+ },
+ "HIGHER_ORDER_FUNCTION_SHOULD_RETURN_COLUMN" : {
+ "message" : [
+ "Function '<funcName>' should return Column, got <returnType>"
+ ]
+ },
+ "NOT_A_COLUMN" : {
+ "message" : [
+ "Argument '<argName>' should be a column, got '<argType>'."
+ ]
+ },
+ "NOT_A_STRING" : {
+ "message" : [
+ "Argument '<argName>' should be a string, got '<argType>'."
Review Comment:
nit: Use backticks.
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1046,6 +1046,63 @@
"Protobuf type not yet supported: <protobufType>."
]
},
+ "PYSPARK" : {
+ "message" : [
+ ""
+ ],
+ "subClass" : {
+ "COLUMN_IN_LIST" : {
+ "message" : [
+ "<funcName> does not allow a column in a list"
+ ]
+ },
+ "HIGHER_ORDER_FUNCTION_SHOULD_RETURN_COLUMN" : {
+ "message" : [
+ "Function '<funcName>' should return Column, got <returnType>"
+ ]
+ },
+ "NOT_A_COLUMN" : {
+ "message" : [
+ "Argument '<argName>' should be a column, got '<argType>'."
Review Comment:
Please, remove `''` around `argName`, and use backticks, see `toSQLId()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
