LuciferYang commented on code in PR #39148:
URL: https://github.com/apache/spark/pull/39148#discussion_r1053982998
##########
core/src/main/scala/org/apache/spark/status/protobuf/ResourceProfileWrapperSerializer.scala:
##########
@@ -18,19 +18,26 @@
package org.apache.spark.status.protobuf
import org.apache.spark.status.ResourceProfileWrapper
-import
org.apache.spark.status.protobuf.ApplicationEnvironmentInfoWrapperSerializer.{deserializeResourceProfileInfo,
serializeResourceProfileInfo}
-object ResourceProfileWrapperSerializer {
- def serialize(input: ResourceProfileWrapper): Array[Byte] = {
+class ResourceProfileWrapperSerializer extends ProtoBufSerDe {
+
+ private val appEnvSerializer = new
ApplicationEnvironmentInfoWrapperSerializer
Review Comment:
We can move the required method to `object ResourceProfileWrapperSerializer`
to avoid creating `appEnvSerializer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
