LuciferYang commented on code in PR #39148:
URL: https://github.com/apache/spark/pull/39148#discussion_r1053984935
##########
core/src/main/scala/org/apache/spark/status/protobuf/ApplicationEnvironmentInfoWrapperSerializer.scala:
##########
@@ -23,8 +23,14 @@ import org.apache.spark.resource.{ExecutorResourceRequest,
TaskResourceRequest}
import org.apache.spark.status.ApplicationEnvironmentInfoWrapper
import org.apache.spark.status.api.v1.{ApplicationEnvironmentInfo,
ResourceProfileInfo, RuntimeInfo}
-object ApplicationEnvironmentInfoWrapperSerializer {
- def serialize(input: ApplicationEnvironmentInfoWrapper): Array[Byte] = {
+class ApplicationEnvironmentInfoWrapperSerializer extends ProtoBufSerDe {
+
+ override val supportClass: Class[_] =
classOf[ApplicationEnvironmentInfoWrapper]
+
+ override def serialize(input: Any): Array[Byte] =
Review Comment:
I'm not sure whether SPI can support generic type, but let me try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
