zhengruifeng commented on code in PR #39149:
URL: https://github.com/apache/spark/pull/39149#discussion_r1053990935
##########
python/pyspark/sql/connect/column.py:
##########
@@ -54,18 +55,18 @@
from pyspark.sql.connect.types import pyspark_types_to_proto_types
if TYPE_CHECKING:
- from pyspark.sql.connect._typing import ColumnOrName, PrimitiveType
+ from pyspark.sql.connect._typing import ColumnOrName, PrimitiveType,
WindowSpecType
from pyspark.sql.connect.client import SparkConnectClient
import pyspark.sql.connect.proto as proto
-JVM_BYTE_MIN = -(1 << 7)
-JVM_BYTE_MAX = (1 << 7) - 1
-JVM_SHORT_MIN = -(1 << 15)
-JVM_SHORT_MAX = (1 << 15) - 1
-JVM_INT_MIN = -(1 << 31)
-JVM_INT_MAX = (1 << 31) - 1
-JVM_LONG_MIN = -(1 << 63)
-JVM_LONG_MAX = (1 << 63) - 1
+JVM_BYTE_MIN: int = -(1 << 7)
+JVM_BYTE_MAX: int = (1 << 7) - 1
+JVM_SHORT_MIN: int = -(1 << 15)
+JVM_SHORT_MAX: int = (1 << 15) - 1
+JVM_INT_MIN: int = -(1 << 31)
+JVM_INT_MAX: int = (1 << 31) - 1
+JVM_LONG_MIN: int = -(1 << 63)
Review Comment:
add the types here, otherwise `Cannot determine type of "JVM_LONG_MIN"
[has-type]` in `window.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
