zhengruifeng commented on code in PR #39149:
URL: https://github.com/apache/spark/pull/39149#discussion_r1055004034
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -623,6 +625,16 @@ class SparkConnectPlanner(session: SparkSession) {
val children =
fun.getArgumentsList.asScala.toSeq.map(transformExpression)
Some(In(children.head, children.tail))
+ case "nth_value" if fun.getArgumentsCount == 3 =>
Review Comment:
if we fix it by add a new constructor in `NthValue`, then I guess it will
also change the sql syntax:
before:
`SELECT nth_value(four, 0) OVER (ORDER BY ten), ten, four FROM tenk1;`
after:
`SELECT nth_value(four, 0) OVER (ORDER BY ten), ten, four FROM tenk1;`
`SELECT nth_value(four, 0, TRUE) OVER (ORDER BY ten), ten, four FROM tenk1;`
// new parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
