grundprinzip commented on code in PR #39091:
URL: https://github.com/apache/spark/pull/39091#discussion_r1055538038
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -338,6 +340,22 @@ class SparkConnectPlanner(session: SparkSession) {
}
}
+ private def transformCollectMetrics(rel: proto.CollectMetrics): LogicalPlan
= {
+ val metrics = rel.getMetricsList.asScala.map { expr =>
+ Column(transformExpression(expr))
+ }
+
+ if (rel.getIsObservation) {
Review Comment:
This explanation is not fully correct. The `Observation` class uses event
listeners to be able to fetch the metrics as soon as they appear without
waiting for the DS command to finish. Since we're not having an event listener
at this point in time it's not the same thing. Please simplify the PR
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
