hvanhovell commented on code in PR #39091:
URL: https://github.com/apache/spark/pull/39091#discussion_r1055797044
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -338,6 +340,22 @@ class SparkConnectPlanner(session: SparkSession) {
}
}
+ private def transformCollectMetrics(rel: proto.CollectMetrics): LogicalPlan
= {
+ val metrics = rel.getMetricsList.asScala.map { expr =>
+ Column(transformExpression(expr))
+ }
+
+ if (rel.getIsObservation) {
Review Comment:
We don't need Observation here. We just need to send the observed metrics as
part of the response stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
