dongjoon-hyun commented on code in PR #39133:
URL: https://github.com/apache/spark/pull/39133#discussion_r1056874155


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreePatterns.scala:
##########
@@ -134,6 +134,7 @@ object TreePattern extends Enumeration  {
   val UNRESOLVED_WINDOW_EXPRESSION: Value = Value
 
   // Unresolved Plan patterns (Alphabetically ordered)
+  val TABLE_VALUED_FUNCTION_WITH_ALIAS: Value = Value

Review Comment:
   Since we already have `UNRESOLVED_TABLE_VALUED_FUNCTION`, according to the 
convention,
   `TABLE_VALUED_FUNCTION_WITH_ALIAS` -> 
`UNRESOLVED_TABLE_VALUED_FUNCTION_WITH_ALIAS`?



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreePatterns.scala:
##########
@@ -134,6 +134,7 @@ object TreePattern extends Enumeration  {
   val UNRESOLVED_WINDOW_EXPRESSION: Value = Value
 
   // Unresolved Plan patterns (Alphabetically ordered)
+  val TABLE_VALUED_FUNCTION_WITH_ALIAS: Value = Value

Review Comment:
   Since we already have `UNRESOLVED_TABLE_VALUED_FUNCTION`, according to the 
convention,
   `TABLE_VALUED_FUNCTION_WITH_ALIAS` -> 
`UNRESOLVED_TABLE_VALUED_FUNCTION_WITH_ALIAS`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to