allisonwang-db commented on code in PR #39133:
URL: https://github.com/apache/spark/pull/39133#discussion_r1057781800
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreePatterns.scala:
##########
@@ -134,6 +134,7 @@ object TreePattern extends Enumeration {
val UNRESOLVED_WINDOW_EXPRESSION: Value = Value
// Unresolved Plan patterns (Alphabetically ordered)
+ val TABLE_VALUED_FUNCTION_WITH_ALIAS: Value = Value
Review Comment:
I was thinking about using `UNRESOLVED_TABLE_VALUED_FUNCTION_WITH_ALIAS` but
we need to distinguish between
1) an unresolved table-valued function with a string function name and
2) an unresolved table-valued function that has been looked up in the
function registry, but its function body (logical plan) and output aliases have
not been resolved yet.
So if we use `UNRESOLVED_TABLE_VALUED_FUNCTION_WITH_ALIAS`, it can be
confusing to make it a unary node vs a leaf node like
`UNRESOLVED_TABLE_VALUED_FUNCTION`.
Let me know what you think @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
