HyukjinKwon commented on code in PR #39294: URL: https://github.com/apache/spark/pull/39294#discussion_r1059730693
########## connector/connect/dev/detect_breaking_changes.sh: ########## @@ -0,0 +1,36 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +if [[ $# -gt 0 ]]; then + echo "Illegal number of parameters." + echo "Usage: ./connector/connect/dev/detect_breaking_changes.sh" + exit -1 +fi + + +SPARK_HOME="$(cd "`dirname $0`"/../../..; pwd)" +cd "$SPARK_HOME" + +pushd connector/connect/common/src/main + +buf breaking --against "https://github.com/apache/spark/archive/master.zip#strip_components=1,subdir=connector/connect/common/src/main"; Review Comment: Just noticed that it will have a problem after we release 3.4. For example, let's say we added a new protobuf message in Spark 3.5, and if a followup fixes the protobuf definition, this check will fail. Can we probably use a different status of the GitHub check instead of a failure? The problem here is that it can be false negative that could confuse the developers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
