grundprinzip commented on PR #39294: URL: https://github.com/apache/spark/pull/39294#issuecomment-1368422894
> > If everything else is green and only the Buf check is read someone with the power to merge can decide to simply merge the change. > > > > If breaking change is allowed to merge, how should we record the incompatibility to inform the user when new version release? I understand that `MimaExcludes` is similar to an audit record. That's a great point. Let me look into how we could track this. I'm wondering if it's slightly different for Mima because the base version is pinned. I think we will probably need a track record of breaking changes. One thing I'm wondering is if we should relax the breaking changes check from FILE to WIRE to avoid that simple renames or deprecating fields breaks compatible. Another thing is, let me add a readme about the proposed compatibility requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
