dtenedor commented on code in PR #39362:
URL: https://github.com/apache/spark/pull/39362#discussion_r1060803729
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1943,7 +1944,11 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
Row(Seq(Row(1, 2)), Seq(Map(false -> "def", true -> "jkl"))),
Seq(Map(true -> "xyz"))),
Row(2,
- null,
+ if (config.dataSource != "orc") {
Review Comment:
It looks like this PR breaks the DEFAULT value functionality for the Orc
data source (as shown by this unit test). If anyone is using this
functionality, this PR will make their results incorrect. It would be better if
we can fix the performance regression without changing the behavior. Is there
some profile to show why the performance regression takes place? For example,
is it because this change to the writer function introduces a new level of
function call?
<img width="2235" alt="image"
src="https://user-images.githubusercontent.com/99207096/210409729-272a12c0-805f-4849-9a0b-4e7677e10575.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/99207096/210409729-272a12c0-805f-4849-9a0b-4e7677e10575.png"](https://user-images.githubusercontent.com/99207096/210409729-272a12c0-805f-4849-9a0b-4e7677e10575.png"){kind=link}