dongjoon-hyun commented on code in PR #39362:
URL: https://github.com/apache/spark/pull/39362#discussion_r1060813160
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1943,7 +1944,11 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
Row(Seq(Row(1, 2)), Seq(Map(false -> "def", true -> "jkl"))),
Seq(Map(true -> "xyz"))),
Row(2,
- null,
+ if (config.dataSource != "orc") {
Review Comment:
Thank you for review, @dtenedor .
- Please see
https://github.com/apache/spark/pull/39301#discussion_r1059239575 . We have a
benchmark to detect this kind of perf regression. You can run it locally in
your environment.
- This is a partial revert to the original code which is the existing
behavior before your PR like the previous Spark. As I mentioned in the PR
description, [SPARK-39862](https://issues.apache.org/jira/browse/SPARK-39862)
should propose a fix without perf regression.
New feature is good as long as not breaking the old behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
