LuciferYang commented on code in PR #39385: URL: https://github.com/apache/spark/pull/39385#discussion_r1062138688
########## sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala: ########## @@ -1007,6 +1002,34 @@ class SQLAppStatusListenerSuite extends SharedSparkSession with JsonTestUtils } } +class SQLAppStatusListenerWithInMemoryStoreSuite extends SQLAppStatusListenerSuite { + override protected def createStatusStore(): SQLAppStatusStore = { + val conf = sparkContext.conf + kvstore = new ElementTrackingStore(new InMemoryStore, conf) + val listener = new SQLAppStatusListener(conf, kvstore, live = true) + new SQLAppStatusStore(kvstore, Some(listener)) + } +} + +class SQLAppStatusListenerWithRocksDBBackendSuite extends SQLAppStatusListenerSuite { + private val storePath = Utils.createTempDir() Review Comment: still make `storePath` as class field and override `afterAll` to delete base `storePath` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org