dongjoon-hyun commented on code in PR #39385:
URL: https://github.com/apache/spark/pull/39385#discussion_r1062012012
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala:
##########
@@ -178,3 +177,35 @@ class AllExecutionsPageSuite extends SharedSparkSession
with BeforeAndAfter {
}
}
+class AllExecutionsPageWithInMemoryStoreSuite extends AllExecutionsPageSuite {
+ override protected def createStatusStore: SQLAppStatusStore = {
+ val conf = sparkContext.conf
+ kvstore = new ElementTrackingStore(new InMemoryStore, conf)
+ val listener = new SQLAppStatusListener(conf, kvstore, live = true)
+ new SQLAppStatusStore(kvstore, Some(listener))
+ }
+}
+
+class AllExecutionsPageWithRocksDBBackendSuite extends AllExecutionsPageSuite {
+ // TODO: SPARK-41882 remove this field after RocksDB can automatically
cleanup
Review Comment:
Instead of this style, please create a new real JIRA ID and point it by
using `IDed TODO` style, `TODO(SPARK-12345)`.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala:
##########
@@ -178,3 +177,35 @@ class AllExecutionsPageSuite extends SharedSparkSession
with BeforeAndAfter {
}
}
+class AllExecutionsPageWithInMemoryStoreSuite extends AllExecutionsPageSuite {
+ override protected def createStatusStore: SQLAppStatusStore = {
+ val conf = sparkContext.conf
+ kvstore = new ElementTrackingStore(new InMemoryStore, conf)
+ val listener = new SQLAppStatusListener(conf, kvstore, live = true)
+ new SQLAppStatusStore(kvstore, Some(listener))
+ }
+}
+
+class AllExecutionsPageWithRocksDBBackendSuite extends AllExecutionsPageSuite {
+ // TODO: SPARK-41882 remove this field after RocksDB can automatically
cleanup
+ private var storePath: File = _
+
+ override protected def createStatusStore(): SQLAppStatusStore = {
+ val conf = sparkContext.conf
+ storePath = Utils.createTempDir()
+ conf.set(LIVE_UI_LOCAL_STORE_DIR, storePath.getCanonicalPath)
+ val appStatusStore = AppStatusStore.createLiveStore(conf)
+ kvstore = appStatusStore.store.asInstanceOf[ElementTrackingStore]
+ val listener = new SQLAppStatusListener(conf, kvstore, live = true)
+ new SQLAppStatusStore(kvstore, Some(listener))
+ }
+
+ // TODO: SPARK-41882 remove this method after RocksDB can automatically
cleanup
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
