srielau commented on code in PR #39402:
URL: https://github.com/apache/spark/pull/39402#discussion_r1062693787
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -789,7 +789,7 @@
},
"INVALID_PARAMETER_VALUE" : {
"message" : [
- "The value of parameter(s) '<parameter>' in <functionName> is invalid:
<expected>"
+ "The value of parameter(s) '<parameter>' in <functionName> is invalid:
<value>"
Review Comment:
I think we're trying to put a square peg into a round hole here.
I see three choices:
1) Add subclasses
2) Add dedicated error classes for these special case functions which speak
to their unique requirements
3) a combo of 1) and 2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
