MaxGekk commented on code in PR #39402:
URL: https://github.com/apache/spark/pull/39402#discussion_r1063619150


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -789,7 +789,7 @@
   },
   "INVALID_PARAMETER_VALUE" : {
     "message" : [
-      "The value of parameter(s) '<parameter>' in <functionName> is invalid: 
<expected>"
+      "The value of parameter(s) '<parameter>' in <functionName> is invalid: 
<value>"

Review Comment:
   > Can I do that? @MaxGekk @srielau
   
   Yep, please, do that. But could you simplify sub-names like:
   - INVALID_PARAMETER_VALUE.AES_KEY
   - INVALID_PARAMETER_VALUE.PATTERN
   - INVALID_PARAMETER_VALUE.AES_KEY_LENGTH
   - INVALID_PARAMETER_VALUE.ZERO_INDEX
   
   The parent name indicates that the parameter value is invalid already, don't 
need to repeat it in sub-class names.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to