itholic commented on code in PR #39488:
URL: https://github.com/apache/spark/pull/39488#discussion_r1066525979
##########
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala:
##########
@@ -71,8 +71,8 @@ private[image] class ImageFileFormat extends FileFormat with
DataSourceRegister
if (!imageSourceOptions.dropInvalid && requiredSchema.isEmpty) {
Iterator(emptyUnsafeRow)
} else {
- val origin = file.filePath
- val path = new Path(origin)
+ val origin = file.uriEncodedPath
+ val path = file.hadoopPath // TODO (URI)
Review Comment:
Can we file a JIRA and add a link here so that we don't forget ?
e.g.
```scala
// TODO(SPARK-XXXXX): <add short summary for the TODO here would be great>
val path = file.hadoopPath
```
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScan.scala:
##########
@@ -163,7 +163,7 @@ trait FileScan extends Scan
}
if (splitFiles.length == 1) {
- val path = new Path(splitFiles(0).filePath)
+ val path = splitFiles(0).hadoopPath // TODO (URI)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
