databricks-david-lewis commented on code in PR #39488:
URL: https://github.com/apache/spark/pull/39488#discussion_r1070791606
##########
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java:
##########
@@ -383,6 +383,7 @@ public static File createTempDir() throws IOException {
public static File createTempDir(String root, String namePrefix) throws
IOException {
if (root == null) root = System.getProperty("java.io.tmpdir");
if (namePrefix == null) namePrefix = "spark";
+ namePrefix = namePrefix + " with a space";
Review Comment:
In my brief search I found that they all came to this method in the end
(withTempDir, etc). I'm actually undoing this change for now, because it causes
too many failures and I don't have the bandwidth to fix the tests right now.
Here is a PR in my branch where I made only this change:
https://github.com/databricks-david-lewis/spark-opensource/pull/2.
I am hoping to fix the problems with spark's tests, and then propose that as
a PR.
##########
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java:
##########
@@ -383,6 +383,7 @@ public static File createTempDir() throws IOException {
public static File createTempDir(String root, String namePrefix) throws
IOException {
if (root == null) root = System.getProperty("java.io.tmpdir");
if (namePrefix == null) namePrefix = "spark";
+ namePrefix = namePrefix + " with a space";
Review Comment:
In my brief search I found that they all came to this method in the end
(withTempDir, etc). I'm actually undoing this change for now, because it causes
too many failures and I don't have the bandwidth to fix the tests right now.
Here is a PR in my branch where I made only this change:
https://github.com/databricks-david-lewis/spark-opensource/pull/2.
I am hoping to fix the problems with spark's tests, and then propose that as
a PR, but I don't know when I will be able to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
