Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6139#issuecomment-103614825
@holdenk Thanks, glad this PR pointed out that the TestParams class didn't
exactly follow the rules! The setParams() method isn't used anywhere, so it
could be removed. (It's not overriding anything, so it won't be called from
elsewhere.) Other than that, it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
