gengliangwang commented on code in PR #39509:
URL: https://github.com/apache/spark/pull/39509#discussion_r1067341325
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupByAll.scala:
##########
@@ -93,8 +93,9 @@ object ResolveGroupByAll extends Rule[LogicalPlan] {
* end of analysis, so we can tell users that we fail to infer the grouping
columns.
*/
def checkAnalysis(operator: LogicalPlan): Unit = operator match {
- case a: Aggregate if matchToken(a) =>
- if (a.aggregateExpressions.exists(_.exists(_.isInstanceOf[Attribute]))) {
+ case a: Aggregate if a.aggregateExpressions.forall(_.resolved) &&
matchToken(a) =>
Review Comment:
Nit: there are some codes duplicated with the `apply` method. We can
consider simple refactors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
