cloud-fan commented on code in PR #39517: URL: https://github.com/apache/spark/pull/39517#discussion_r1067668533
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala: ########## @@ -46,35 +46,42 @@ object AgnosticEncoders { override val clsTag: ClassTag[Option[E]] = ClassTag(classOf[Option[E]]) } - case class ArrayEncoder[E](element: AgnosticEncoder[E]) + case class ArrayEncoder[E](element: AgnosticEncoder[E], containsNull: Boolean) extends AgnosticEncoder[Array[E]] { override def isPrimitive: Boolean = false - override def dataType: DataType = ArrayType(element.dataType, element.nullable) + override def dataType: DataType = ArrayType(element.dataType, containsNull) override val clsTag: ClassTag[Array[E]] = element.clsTag.wrap } - case class IterableEncoder[C <: Iterable[E], E]( + case class IterableEncoder[C, E]( override val clsTag: ClassTag[C], - element: AgnosticEncoder[E]) + element: AgnosticEncoder[E], + containsNull: Boolean, + override val lenientSerialization: Boolean) Review Comment: what does lenient mean for a `IterableEncoder`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org