wankunde commented on code in PR #37922:
URL: https://github.com/apache/spark/pull/37922#discussion_r1067694549
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala:
##########
@@ -321,6 +321,12 @@ class BlockManagerMasterEndpoint(
}
private def removeShuffle(shuffleId: Int): Future[Seq[Boolean]] = {
+ val mergerLocations =
+ if (Utils.isPushBasedShuffleEnabled(conf, isDriver)) {
+ mapOutputTracker.getShufflePushMergerLocations(shuffleId)
+ } else {
+ Seq.empty[BlockManagerId]
+ }
Review Comment:
The following is my debug logs:
```
23/01/11 21:34:33 WARN [block-manager-storage-async-thread-pool-120]
storage.BlockManagerStorageEndpoint:72 : Call
mapOutputTracker.unregisterShuffle for 12
23/01/11 21:34:33 WARN [dispatcher-BlockManagerMaster]
storage.BlockManagerMasterEndpoint:72 : Call getShufflePushMergerLocations for
12
23/01/11 21:34:33 WARN [block-manager-storage-async-thread-pool-74]
storage.BlockManagerStorageEndpoint:72 : Call
mapOutputTracker.unregisterShuffle for 11
23/01/11 21:34:33 WARN [dispatcher-BlockManagerMaster]
storage.BlockManagerMasterEndpoint:72 : Call getShufflePushMergerLocations for
11
```
If we move the code after RemoveShuffle RPC to BlockManagerStorageEndpoint,
we may get empty merge locations.
```
val removeMsg = RemoveShuffle(shuffleId)
val removeShuffleFromExecutorsFutures = blockManagerInfo.values.map { bm
=>
bm.storageEndpoint.ask[Boolean](removeMsg).recover {
// use false as default value means no shuffle data were removed
handleBlockRemovalFailure("shuffle", shuffleId.toString,
bm.blockManagerId, false)
}
}.toSeq
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
