wankunde commented on code in PR #37922:
URL: https://github.com/apache/spark/pull/37922#discussion_r1067998412
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala:
##########
@@ -321,6 +321,12 @@ class BlockManagerMasterEndpoint(
}
private def removeShuffle(shuffleId: Int): Future[Seq[Boolean]] = {
+ val mergerLocations =
+ if (Utils.isPushBasedShuffleEnabled(conf, isDriver)) {
+ mapOutputTracker.getShufflePushMergerLocations(shuffleId)
+ } else {
+ Seq.empty[BlockManagerId]
+ }
Review Comment:
Thanks @mridulm , add this UT.
Yes, `RemoveShuffle` is sent to the storage endpoint in `removeShuffle`.
Add more debug log in our test cluster, shuffle 2 will be removed by thread
`block-manager-storage-async-thread-pool-51` in `BlockManagerStorageEndpoint`
class
```
23/01/12 00:43:40 WARN [block-manager-storage-async-thread-pool-51]
storage.BlockManagerStorageEndpoint:72 : Call
mapOutputTracker.unregisterShuffle for 2
23/01/12 00:43:40 WARN [block-manager-storage-async-thread-pool-51]
spark.MapOutputTrackerMaster:72 : shuffleStatuses.remove(shuffleId) for shuffle
2
23/01/12 00:43:40 WARN [dispatcher-BlockManagerMaster]
storage.BlockManagerMasterEndpoint:72 : Call getShufflePushMergerLocations for 2
23/01/12 00:43:40 WARN [dispatcher-BlockManagerMaster]
spark.MapOutputTrackerMaster:72 : shuffleStatuses.get(shuffleId) = None
23/01/12 00:43:40 WARN [dispatcher-BlockManagerMaster]
spark.MapOutputTrackerMaster:72 :
shuffleStatuses.get(shuffleId).map(_.getShufflePushMergerLocations) = None
23/01/12 00:43:40 WARN [Spark Context Cleaner]
spark.MapOutputTrackerMaster:72 : shuffleStatuses.remove(shuffleId) for shuffle
2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
