cloud-fan commented on code in PR #39408:
URL: https://github.com/apache/spark/pull/39408#discussion_r1069349167
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala:
##########
@@ -214,9 +214,20 @@ object FileSourceStrategy extends Strategy with
PredicateHelper with Logging {
.filterNot(partitionColumns.contains)
// Metadata attributes are part of a column of type struct up to this
point. Here we extract
- // this column from the schema.
+ // this column from the schema and specify a matcher for that.
+ object MetadataStructColumn {
+ def unapply(attributeReference: AttributeReference):
Option[AttributeReference] = {
Review Comment:
how about returning `Option[StructType]`? I'm looking at
`metadataStructOpt`, and seems we only need its struct type. The same to
rebinding predicates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
