grundprinzip commented on code in PR #39585: URL: https://github.com/apache/spark/pull/39585#discussion_r1070822033
########## python/pyspark/sql/connect/udf.py: ########## @@ -0,0 +1,184 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +""" +User-defined function related classes and functions +""" +import functools +from typing import Callable, Any, TYPE_CHECKING, Optional + +from pyspark import cloudpickle +from pyspark.sql.connect.expressions import ColumnReference, PythonFunction, PythonUDF +from pyspark.sql.connect.column import Column +from pyspark.sql.types import DataType + + +if TYPE_CHECKING: + from pyspark.sql.connect._typing import ( + ColumnOrName, + DataTypeOrString, + UserDefinedFunctionLike, + ) + from pyspark.sql.types import StringType + from pyspark.sql.session import SparkSession + + +def _wrap_function( Review Comment: is this still called? Sincere the client does not have a JVM, it should not. ########## connector/connect/common/src/main/protobuf/spark/connect/expressions.proto: ########## @@ -216,6 +218,19 @@ message Expression { bool is_user_defined_function = 4; } + message PythonUDF { Review Comment: I'm wondering if it makes sense to generalize this message to something like "session UDF" in which there is a oneof for the different languages. This will avoid logical duplication for the Scala UDF work (and other languages). @hvanhovell what's your take? ########## connector/connect/common/src/main/protobuf/spark/connect/expressions.proto: ########## @@ -43,6 +43,8 @@ message Expression { Window window = 11; UnresolvedExtractValue unresolved_extract_value = 12; UpdateFields update_fields = 13; + PythonFunction python_function = 14; Review Comment: It looks like this message is never used outside the Python UDF so it should not be listed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
