xinrong-meng commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1071829420
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -43,6 +43,8 @@ message Expression {
Window window = 11;
UnresolvedExtractValue unresolved_extract_value = 12;
UpdateFields update_fields = 13;
+ PythonFunction python_function = 14;
Review Comment:
I may want to keep `PythonFunction python_function` in `oneof expr_type` for
now since the generated property `python_function` is used as shown below.
```
class PythonUDF(Expression):
...
def to_plan(self, session: "SparkConnectClient") -> proto.Expression:
...
expr.python_udf.function.CopyFrom(self._func.to_plan(session).python_function)
```
Please let me know if there is a better way to get the PythonFunction
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
