cloud-fan commented on code in PR #39592:
URL: https://github.com/apache/spark/pull/39592#discussion_r1073530920
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala:
##########
@@ -275,8 +276,37 @@ object LogicalPlanIntegrity {
* Some plan transformers (e.g., `RemoveNoopOperators`) rewrite logical
* plans based on this assumption.
*/
- def checkIfExprIdsAreGloballyUnique(plan: LogicalPlan): Boolean = {
- checkIfSameExprIdNotReused(plan) && hasUniqueExprIdsForOutput(plan)
+ def validateExprIdUniqueness(plan: LogicalPlan): Unit = {
Review Comment:
We can add sub error classes in the validation failure error class. But I'd
like to do it later as naming is always a hard problem and may take a lot of
time to reach a consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
