xkrogen commented on code in PR #39592:
URL: https://github.com/apache/spark/pull/39592#discussion_r1081513455
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -304,6 +304,14 @@ object SQLConf {
.stringConf
.createOptional
+ val PLAN_CHANGE_VALIDATION = buildConf("spark.sql.planChangeValidation")
+ .internal()
+ .doc("If true, Spark will validate all the plan changes made by
analyzer/optimizer and other " +
+ "catalyst rules, to make sure every rule returns a valid plan")
+ .version("3.4.0")
+ .booleanConf
+ .createWithDefault(false)
Review Comment:
In the latest diff, the code has been updated to:
```scala
val enableValidation =
SQLConf.get.getConf(SQLConf.PLAN_CHANGE_VALIDATION)
// Validate the initial input.
if (Utils.isTesting || enableValidation) {
...
}
```
This looks right to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
