grundprinzip commented on code in PR #39585: URL: https://github.com/apache/spark/pull/39585#discussion_r1082600958
########## connector/connect/common/src/main/protobuf/spark/connect/expressions.proto: ########## @@ -217,6 +218,28 @@ message Expression { bool is_user_defined_function = 4; } + message ScalarInlineUserDefinedFunction { Review Comment: I had a discussion with @hvanhovell and we agreed that the message type should be moved out of the expression message because we want to use the same message at the end of the day for registered and inline function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org